[foreign-preview] RFR: 8280527: Move jdk.incubator.foreign to java.lang.foreign [v3]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Thu Jan 27 11:38:59 UTC 2022
On Thu, 27 Jan 2022 11:12:52 GMT, Julia Boes <jboes at openjdk.org> wrote:
>> To prepare for preview, this change removes the jdk.incubator.foreign module and moves the public classes to java.base/java.lang.foreign, implementation classes to java.base/jdk.internal.foreign respectively.
>>
>> While here, `SystemLookup` is replaced with the method `ClassLoader::findNative` and the methods in `MemoryHandles` are moved to `MethodHandles`. The `@PreviewFeature(feature=PreviewFeature.Feature.FOREIGN)` annotation and the `--enable-preview` flag are added were needed.
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
>
> refactor test helper method and some cleanup
test/jdk/java/foreign/TestVarArgs.java line 68:
> 66: }
> 67:
> 68: static final NativeSymbol VARARGS_ADDR = new NativeTestHelper().findNativeOrThrow("varargs");
Maybe instead of creating `newNativeTestHelper` you can extend that class (as in other cases)
-------------
PR: https://git.openjdk.java.net/panama-foreign/pull/633
More information about the panama-dev
mailing list