[foreign-preview] RFR: 8280527: Move jdk.incubator.foreign to java.lang.foreign [v4]
Jorn Vernee
jvernee at openjdk.java.net
Thu Jan 27 17:42:06 UTC 2022
On Thu, 27 Jan 2022 16:57:56 GMT, Julia Boes <jboes at openjdk.org> wrote:
>> To prepare for preview, this change removes the jdk.incubator.foreign module and moves the public classes to java.base/java.lang.foreign, implementation classes to java.base/jdk.internal.foreign respectively.
>>
>> While here, `SystemLookup` is replaced with the method `ClassLoader::findNative` and the methods in `MemoryHandles` are moved to `MethodHandles`. The `@PreviewFeature(feature=PreviewFeature.Feature.FOREIGN)` annotation and the `--enable-preview` flag are added were needed.
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
>
> revert to static helper method for consistency
This looks good. Just one minor copyright nit inline.
Let's not get too hung up on the test changes.
src/java.base/share/classes/java/lang/invoke/VarHandles.java line 2:
> 1: /*
> 2: * Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
This file has a copyright year change, but no actual changes.
-------------
Marked as reviewed by jvernee (Committer).
PR: https://git.openjdk.java.net/panama-foreign/pull/633
More information about the panama-dev
mailing list