[foreign-preview] RFR: 8282805: Javadoc for restricted method does not reflect updates to --enable-native-access

Athijegannathan Sundararajan sundar at openjdk.java.net
Tue Mar 8 15:58:24 UTC 2022


On Tue, 8 Mar 2022 15:05:54 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This simple patch updates the javadoc comments for restricted methods to reflect the updated behavior of the `--enable-native-access` flag.
> All the `@throws` tags in restricted methods are updated, as well as the toplevel package javadoc section on restricted methods.

LGTM

src/java.base/share/classes/java/lang/foreign/package-info.java line 233:

> 231:  * can be used). If this option is specified, access to restricted methods is only granted to the modules listed by that
> 232:  * option. If no command line option is specified, access to restricted method is enabled for all modules, but
> 233:  * access to restricted methods will result in runtime warnings.

“If this option is specified…” for the positive case
“If no command line option is specified” for the negative case

Should it be “If this option is not specified..” for negative case?

-------------

Marked as reviewed by sundar (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/665


More information about the panama-dev mailing list