[foreign-preview] Integrated: 8280597: Refactor java.lang.invoke.MethodHandles::memoryAccessVarHandle

Maurizio Cimadamore mcimadamore at openjdk.java.net
Tue Mar 8 16:12:31 UTC 2022


On Mon, 7 Mar 2022 13:56:55 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch renames `MethodHandles::memoryAccessVarHandle` to `MethodHandles:memorySegmentViewVarHandle`, which is consistent with other methods in that class like `byteArrayViewVarHandle` and `byteBufferViewVarHandle`.
> 
> When doing this, I also renamed several implementation classes and methods (included some automatically generated ones) to use the new names, and be more consistent with the naming scheme adopted for byte buffer var handle views.
> 
> Finally, I tweaked the javadoc to use the new name. When doing this, I realized that the toplevel package javadoc was diving into var handles and combinators way too soon, so I have beefed up the memory segment dereference section (in the `MemorySegment` javadoc) and added a link from the package javadoc to that section.
> 
> I'm still not 100% happy about how the memory segment javadoc looks, but for unrelated reasons, and I will deal with that in a separate pass.

This pull request has now been integrated.

Changeset: e0591c0a
Author:    Maurizio Cimadamore <mcimadamore at openjdk.org>
URL:       https://git.openjdk.java.net/panama-foreign/commit/e0591c0abe25fac1dca144de24e40682a721a6b0
Stats:     1354 lines in 22 files changed: 649 ins; 635 del; 70 mod

8280597: Refactor java.lang.invoke.MethodHandles::memoryAccessVarHandle

Reviewed-by: sundar

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/663


More information about the panama-dev mailing list