[foreign-preview] RFR: More javadoc cleanup. [v3]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Mon Mar 14 22:15:07 UTC 2022


> I noticed more inconsistencies in the foreogn API javadoc. For instance, the text saying that a class is value-based was in some cases repeated twice, once inside the main javadoc, and another as an `@implSpec`. I've removed all duplicates, and opted for the `@implSpec` version, that is more succint and more separated from the main javadoc text.
> 
> I have also reworked the javadoc of `MemorySession` and `MemorySegment`. The `MemorySession` javadoc contained a big list of all the possible things that can be associated with a session and what happens to them once the session is closed. I found this to be redundant and I've decided to streamline the text a little.
> 
> As for `MemorySegment`, the javadoc has evolved into many different small subsections. I've consolidated the text, by quickly listing all types of memory segments at the top. I've also dropped the section on "views" (which is something that is far less important in this iteraton of the API) and created a new session on slicing, which covers both slices and stream support. The result makes, I think, a lot more sense.
> 
> Finally, I've tweaked some text in `SegmentAllocator` where we're still referring to `array` event though the signatures of the methods take a varargs.

Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:

  Address review comments

-------------

Changes:
  - all: https://git.openjdk.java.net/panama-foreign/pull/670/files
  - new: https://git.openjdk.java.net/panama-foreign/pull/670/files/c9805796..9c9f9da5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=670&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=panama-foreign&pr=670&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/panama-foreign/pull/670.diff
  Fetch: git fetch https://git.openjdk.java.net/panama-foreign pull/670/head:pull/670

PR: https://git.openjdk.java.net/panama-foreign/pull/670


More information about the panama-dev mailing list