[vectorIntrinsics] RFR: Load store memory segment [v2]

Paul Sandoz psandoz at openjdk.java.net
Wed Mar 30 18:47:45 UTC 2022


On Wed, 30 Mar 2022 08:10:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct method name convention for scoped access
>
> src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template line 674:
> 
>> 672:     private static
>> 673:     <V extends VectorSupport.Vector<E>, E>
>> 674:     void storeIntoMemorySegmentScoped(ScopedMemoryAccess.Scope scope,
> 
> I believe the rest of the class uses "internal" as a suffix for the scoped method

Done.

> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java line 3527:
> 
>> 3525:      * {@link #intoMemorySegment(MemorySegment,long,ByteOrder,VectorMask)
>> 3526:      * intoMemorySegment()} as follows:
>> 3527:      * <pre>{@code
> 
> you might want to revisit later to use code snippets

Yes, that's a good point, we need to revisit all of the doc.

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/187


More information about the panama-dev mailing list