[vectorIntrinsics] RFR: Load store memory segment [v3]

Radoslaw Smogura duke at openjdk.java.net
Wed Mar 30 19:59:47 UTC 2022


On Wed, 30 Mar 2022 19:02:53 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> This is the initial implementation for loading/storing vectors from/to memory segments.
>> 
>> Some of the changes are related to `int` -> `long` for the offset. I had to change the load/store intrinsic signatures to accept an offset as a `long`. This does not affect the C2 implementation, only the fallback lambdas. So in some cases there is a downcast to `int`, which is safe because the original input was an `int` e.g. the offset for primitive array access. 
>> 
>> Some changes related to module dependency and memory segment proxies will go away when the Memory Segment API is integrated into `java.base` as a preview API.
>>  
>> There is still more work to do but i wanted to get this in now and iterate:
>> - I will remove the `byte[]` and `ByteBuffer` accepting load/store methods in a following PR.
>> - some additional negative tests are required, specifically if a scope of segment is not alive, or the segment covers a heap array other than `byte[]`.
>
> Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use assertThrows.

Very minor, I wonder if we should adjust `loopBound` to long sizes, too (I don't see it in diff)?

-------------

PR: https://git.openjdk.java.net/panama-vector/pull/187


More information about the panama-dev mailing list