[foreign-memaccess+abi] RFR: 8294309: Downcall and Upcall unboxing code should reject heap segments [v3]

[Maurizio Cimadamore]

On Tue, 4 Oct 2022 12:51:15 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Recently I noticed that we don't check for heap segments anymore when unboxing memory segments to be passed to native code as addresses. This allows someone to pass a heap segment, which will be unboxed simply by calling `MemorySegment::address` which for heap segments returns the byte offset into the array. This is of course not a valid pointer.
>> 
>> This patch changes the unboxing logic to reject heap segments with an `IllegalArgumentException`.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove spurious import

Marked as reviewed by mcimadamore (Committer).

-------------

PR: https://git.openjdk.org/panama-foreign/pull/737