[foreign-memaccess+abi] RFR: 8294986: Possible mismatched acquire/release in binding specializer

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Oct 11 15:40:18 UTC 2022


On Tue, 11 Oct 2022 15:31:59 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Looks good. Not super sure about the `assert`, which will only fire with assertion enabled. Historically I've been using `assert` keywords sparingly and using `throw new AssertError` more (especially in the javac code base), as that is guaranteed to fail. But that is subjective.

Also, in the `SharedSession` implementation we throw a runtime exception in case of too many releases.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/739


More information about the panama-dev mailing list