[foreign-memaccess+abi] RFR: 8294621: Copying from a StringCharBuffer-backed MemorySegment results in crash [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Oct 14 13:52:27 UTC 2022
On Fri, 14 Oct 2022 13:21:14 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Why do we need a newline there?
>
> IIRC, unix file specification says that every line in a file should end with a newline. I believe this is also why GitHub warns about it.
It's one of the custom checks we have always applied to JDK code. E.g. no trailing spaces, newline at the end. It's odd that jcheck says it's fine. I recall these things being enforced more strictly in the past (e.g. via HG hooks).
-------------
PR: https://git.openjdk.org/panama-foreign/pull/741
More information about the panama-dev
mailing list