[foreign-memaccess+abi] RFR: 8275584: Incorrect stack spilling in CallArranger on MacOS/AArch64 [v2]

Nick Gasson ngasson at openjdk.org
Mon Oct 24 13:08:55 UTC 2022


On Fri, 21 Oct 2022 15:50:22 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove sign-extension XXX
>
> src/hotspot/cpu/aarch64/foreignGlobals_aarch64.cpp line 134:
> 
>> 132:       assert(to_reg.segment_mask() == REG64_MASK, "only moves to 64-bit registers supported");
>> 133:       switch (from_reg.stack_size()) {
>> 134:         // FIXME these loads zero upper bits of the register
> 
> I'm not sure about this: I'll try creating a test next week.

I think this is correct as-is (I tested with spilled negative values).

-------------

PR: https://git.openjdk.org/panama-foreign/pull/746


More information about the panama-dev mailing list