[foreign-memaccess+abi] RFR: 8275644: Replace VMReg in shuffling code with something more fine grained. [v5]

[Jorn Vernee]

On Tue, 6 Sep 2022 15:21:36 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix MSVC compilation
>
> src/hotspot/cpu/aarch64/foreignGlobals_aarch64.cpp line 100:
> 
>> 98: }
>> 99: 
>> 100: constexpr int RFP_BIAS = 16; // skip old rfp and lr
> 
> Should this be `static constexpr`?

Can do.

> src/hotspot/cpu/aarch64/vmstorage_aarch64.inline.hpp line 25:
> 
>> 23: 
>> 24: #ifndef SHARE_PRIMS_VMSTORAGE_AARCH64
>> 25: #define SHARE_PRIMS_VMSTORAGE_AARCH64
> 
> Should this be `CPU_AARCH64_VMSTORAGE_AARCH64_HPP`?

Yes. I messed up this pattern for all the new header files. Thanks for catching!

-------------

PR: https://git.openjdk.org/panama-foreign/pull/699