[foreign-memaccess+abi] Integrated: 8293495: Revisit name of SymbolLookup::lookup
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu Sep 8 12:11:32 UTC 2022
On Wed, 7 Sep 2022 16:41:25 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This simple patch changes the name of SymbolLookup::lookup to SymbolLookup::find.
>
> This change was suggested during many rounds of API reviews, as the term "lookup" can refer to both a noun and a verb and, sadly, the API is using both forms.
>
> Since we already have a precedent in the JDK for using Lookup in the noun form (e.g. method handle lookup), I have decided to rename the method to something more neutral like "find", which, coincidentally is also the term we settled on in the javadoc in order to avoid confusion.
This pull request has now been integrated.
Changeset: 2bdb662a
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/panama-foreign/commit/2bdb662a786a34a0d7cb7014b73cb74243a4c613
Stats: 70 lines in 19 files changed: 0 ins; 0 del; 70 mod
8293495: Revisit name of SymbolLookup::lookup
Reviewed-by: sundar
-------------
PR: https://git.openjdk.org/panama-foreign/pull/716
More information about the panama-dev
mailing list