[foreign-memaccess+abi] RFR: 8292037: Consider moving Linker::methodType as FunctionDescriptor::toMethodType [v3]
Jorn Vernee
jvernee at openjdk.org
Tue Sep 13 15:38:59 UTC 2022
On Tue, 13 Sep 2022 15:34:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/java/lang/foreign/FunctionDescriptor.java line 110:
>
>> 108: * @return the method type consisting of the carrier types of the layouts in this function descriptor
>> 109: * @throws IllegalArgumentException if one or more layouts in the function descriptor can not be mapped to carrier
>> 110: * types (e.g. if they are sequence layouts or padding layouts).
>
> Suggestion:
>
> * types (e.g. if they are padding layouts).
I've removed the support for SequenceLayout now, so I think this is currently correct?
-------------
PR: https://git.openjdk.org/panama-foreign/pull/717
More information about the panama-dev
mailing list