[foreign-memaccess+abi] Integrated: 8292037: Consider moving Linker::methodType as FunctionDescriptor::toMethodType

[Jorn Vernee]

On Wed, 7 Sep 2022 17:35:36 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> This patch moves `Linker::methodType` to `FunctionDescriptor` as `carrierMethodType`.
> 
> I went with the name `carrierMethodType` instead of `toMethodType` (as suggested by the JBS issue) since I think it's a bit more descriptive. Please let me know your thoughts.
> 
> This issue also suggest adding support for `SequenceLayout` in the linker implementation. I think adding support in FunctionDescriptor could be a good idea, but since passing arrays by value is not supported in C, I feel like we should reject it in the linker implementations we have (which are all C as well). Of course, we could make it work any way by interpreting such cases as a pointer layout instead, but it's a case of being able to do the same thing in multiple ways (which I think can be confusing), and might actually be surprising if someone passes the wrong layout to the linker by accident, but it doesn't get "caught".
> 
> I've added support for `SequenceLayout` to `FunctionDescriptor`, but it is still rejected in the type classification logic.

This pull request has now been integrated.

Changeset: f890e56b
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.org/panama-foreign/commit/f890e56b9357bff8578e1efe8a172b1809d639cf
Stats:     104 lines in 12 files changed: 59 ins; 32 del; 13 mod

8292037: Consider moving Linker::methodType as FunctionDescriptor::toMethodType

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/panama-foreign/pull/717