[foreign-memaccess+abi] RFR: 8291873: Implement return value normalization in Java [v2]

Jorn Vernee jvernee at openjdk.org
Thu Sep 15 12:57:59 UTC 2022


On Thu, 15 Sep 2022 12:46:36 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Non-zero byte test
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java line 686:
> 
>> 684:             if (toType == boolean.class) {
>> 685:                 // implement least significant byte non-zero test
>> 686:                 Label falseLabel = new Label();
> 
> Optional: couldn't we call `Utils.byteToBoolean`?

Yes we can, good point! (stuck in my head with that we couldn't call internal code)

-------------

PR: https://git.openjdk.org/panama-foreign/pull/720


More information about the panama-dev mailing list