[foreign-memaccess+abi] RFR: 8293510: Code style issues in the foreign API [v2]

[Jorn Vernee]

On Fri, 16 Sep 2022 10:41:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge foreign-memaccess+abi
>>  - Fix import
>>  - Merge with foreign-memaccess+abi
>>  - Break out functionality into Utils
>>  - Reformat public interface declartions
>>  - Cleanup method parameters in internal classes
>>  - Cleanup method parameters in public classes
>>  - Rearrange code
>>  - Fix naming issue
>>  - Merge with foreign-memaccess+abi
>>  - ... and 5 more: https://git.openjdk.org/panama-foreign/compare/3e8ef17b...d8294460
>
> src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 77:
> 
>> 75: 
>> 76:     @ForceInline
>> 77:     AbstractMemorySegmentImpl(long length,
> 
> Here I'm a bit puzzled. Looking at other JDK code, I don't see this rule being applied consistently. I think I'm ok with breaking up long parameter lists (an example of that below) - but doing that for all method decls seems a bit too much IMHO.

Agree, we should follow the style used in the rest of the jdk code, at least in java.base.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/721