[foreign-memaccess+abi] RFR: Rename parameter names

[Maurizio Cimadamore]

On Mon, 19 Sep 2022 12:51:14 GMT, Per Minborg <duke at openjdk.org> wrote:

> This PR renames parameter names to be more consistent across all classes.

Looks good. With respect to `elementLayout` I can see that going both ways. IMHO what we have in the API doesn't look obviously wrong. By replacing that with e.g. `byteLayout` you gain something (e.g. the fact that he layout is that of a byte) but you lose something else (the fact that we're talking about the layout of an array element).

src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 626:

> 624:     /**
> 625:      * Copy the contents of this memory segment into a new byte array.
> 626:      * @param byteLayout the source element layout.

Not sure these changes are a necessary consequence of the parameter naming harmonization. That is, the layout does indicate an array element layout...

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 262:

> 260: 
> 261:     @Override
> 262:     public final byte[] toArray(ValueLayout.OfByte byteLayout) {

Same here.

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.org/panama-foreign/pull/726