[foreign-memaccess+abi] RFR: Change classes into records and fix finality

[Jorn Vernee]

On Mon, 19 Sep 2022 12:33:23 GMT, Per Minborg <duke at openjdk.org> wrote:

> This PR converts some of the regular classes into records. It also fixes some finality issues.
> 
> Note: Some methods with a very long method parameter list have their parameter list broken up into separate lines.

src/java.base/share/classes/jdk/internal/foreign/abi/ABIDescriptor.java line 53:

> 51:                          int shadowSpace,
> 52:                          VMStorage targetAddrStorage,
> 53:                          VMStorage retBufAddrStorage) {

Please move the line splitting changes to a separate PR. I think more discussion is needed on that. But we can move forward with some of the changes in this PR I think.

src/java.base/share/classes/jdk/internal/foreign/abi/VMStorage.java line 38:

> 36:  * @param debugName         the debug name to use
> 37:  */
> 38: public record VMStorage(byte type,

I think this should stay a `class`. VMStorage should not be constructed directly, but one of the factory methods should be used. But, the change to `record` forces the constructor to be public.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/725