[foreign-memaccess+abi] RFR: Change classes into records and fix finality [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Sep 19 14:28:07 UTC 2022
On Mon, 19 Sep 2022 13:14:18 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert changes to VMStorage
>
> src/java.base/share/classes/jdk/internal/foreign/abi/VMStorage.java line 38:
>
>> 36: * @param debugName the debug name to use
>> 37: */
>> 38: public record VMStorage(byte type,
>
> I think this should stay a `class`. VMStorage should not be constructed directly, but one of the factory methods should be used. But, the change to `record` forces the constructor to be public.
Doesn't the same reasoning hold for Binding? E.g. there's a builder there, no?
-------------
PR: https://git.openjdk.org/panama-foreign/pull/725
More information about the panama-dev
mailing list