[foreign-memaccess+abi] RFR: Change classes into records and fix finality [v2]

Jorn Vernee jvernee at openjdk.org
Mon Sep 19 14:53:00 UTC 2022


On Mon, 19 Sep 2022 14:05:40 GMT, Per Minborg <duke at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/foreign/abi/ABIDescriptor.java line 53:
>> 
>>> 51:                          int shadowSpace,
>>> 52:                          VMStorage targetAddrStorage,
>>> 53:                          VMStorage retBufAddrStorage) {
>> 
>> Please move the line splitting changes to a separate PR. I think more discussion is needed on that. But we can move forward with some of the changes in this PR I think.
>
> I will hold back the other splittings. Can we accept the ones here to move forward?

No. We don't have consensus on whether these changes are good or bad, so we should not just move forward with them. We're not in a hurry.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/725


More information about the panama-dev mailing list