[foreign-memaccess+abi] RFR: Split Stream operations, fix final and class properties [v3]

[Maurizio Cimadamore]

On Tue, 20 Sep 2022 14:33:14 GMT, Per Minborg <duke at openjdk.org> wrote:

>> This PR splits Stream operations into separate lines, and fixes some `final` and class issues.
>> 
>> Some smaller issues are also fixed not related to the above.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert some more final declarations

src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java line 261:

> 259:     }
> 260: 
> 261:     private static UnsupportedOperationException newUnsupportedOperationExceptionNotAMappedSegment() {

Suggestion:

    private static UnsupportedOperationException notAMappedSegment() {

src/java.base/share/classes/jdk/internal/foreign/abi/SoftReferenceCache.java line 41:

> 39:     }
> 40: 
> 41:     private class Node {

This should be left alone?

src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java line 46:

> 44: import static sun.security.action.GetBooleanAction.privilegedGetProperty;
> 45: 
> 46: public final class UpcallLinker {

This should be left alone?

src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java line 64:

> 62:     }
> 63: 
> 64:     private UpcallLinker() {

This doesn't buy much since it's internal API.

src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/CallArranger.java line 124:

> 122:     protected CallArranger() {}
> 123: 
> 124:     public final Bindings getBindings(MethodType mt, FunctionDescriptor cDesc, boolean forUpcall) {

final changes  in this class still present

-------------

PR: https://git.openjdk.org/panama-foreign/pull/724