[foreign-memaccess+abi] RFR: Split Stream operations, fix final and class properties [v5]

[Maurizio Cimadamore]

On Wed, 21 Sep 2022 09:36:47 GMT, Per Minborg <duke at openjdk.org> wrote:

>> This PR splits Stream operations into separate lines, and fixes some `final` and class issues.
>> 
>> Some smaller issues are also fixed not related to the above.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update from comments

src/java.base/share/classes/jdk/internal/foreign/Utils.java line 80:

> 78:     }
> 79: 
> 80:     private Utils() {

Please revert this

src/java.base/share/classes/jdk/internal/foreign/abi/BindingInterpreter.java line 33:

> 31: public final class BindingInterpreter {
> 32: 
> 33:     private BindingInterpreter() {

Please revert this

src/java.base/share/classes/jdk/internal/foreign/abi/SharedUtils.java line 392:

> 390:     }
> 391: 
> 392:     public static final class EmptyVaList implements VaList {

Rationale: while this is not strictly needed, I'm more willing to accept it since we had to say something (e.g. non-sealed) anyway. So, if in this case saying `final` is a more apt description, I'm ok with changing it.

src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java line 64:

> 62:     }
> 63: 
> 64:     private UpcallLinker() {

Please revert this

src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/CallArranger.java line 155:

> 153:     }
> 154: 
> 155:     static final class StorageCalculator {

Please revert

-------------

PR: https://git.openjdk.org/panama-foreign/pull/724