[foreign-memaccess+abi] RFR: Split Stream operations, fix final and class properties [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Sep 21 09:52:52 UTC 2022


On Wed, 21 Sep 2022 09:40:24 GMT, Per Minborg <duke at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/foreign/abi/UpcallLinker.java line 64:
>> 
>>> 62:     }
>>> 63: 
>>> 64:     private UpcallLinker() {
>> 
>> This doesn't buy much since it's internal API.
>
> I think it is good practice anyhow. This signals that it is an uninstantiable utility class.

I understand your point of view. However, for these changes we have agreed to commit to a policy of sticking to less controversial changes, to move things forward. Adding `final` and private constructors in impl classes is not widespread practice in JDK code, so we should hold off at the moment (and maybe revisit later).

-------------

PR: https://git.openjdk.org/panama-foreign/pull/724


More information about the panama-dev mailing list