[foreign-memaccess+abi] RFR: 8284300: Explicitly reject layouts that don't have the correct alignment during linking [v2]

Jorn Vernee jvernee at openjdk.org
Wed Sep 21 13:24:03 UTC 2022


On Wed, 21 Sep 2022 13:05:00 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line 101:
> 
>> 99:         if (layout instanceof GroupLayout gl) {
>> 100:             for (MemoryLayout member : gl.memberLayouts()) {
>> 101:                 checkHasNaturalAlignment(member);
> 
> This should use recursive version too, no?

Ah, good catch

-------------

PR: https://git.openjdk.org/panama-foreign/pull/728


More information about the panama-dev mailing list