[foreign-memaccess+abi] Integrated: 8292047: Consider ways to add linkage parameters to downcall handles

[Jorn Vernee]

On Thu, 22 Sep 2022 13:32:09 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> This patch implements a linker option interface, that can be using to indicate additional linkage requirements to the linker.
> 
> The variadic function descriptor support is dropped in favor of using a linker option to indicate the first variadic argument index. I think the switch turned out to be straight forward for users of this feature as well, though a bit more verbose.
> 
> I also experimented with putting linker options on FunctionDescriptor directly, but it increases the complexity of the combinators of FunctionDescriptor. For instance, if an argument layout is inserted somewhere, should the variadic index option also be updated? (a similar issue arises if we support other linker options that include parameter list indexes). As a result of that, it seemed simpler to just move the linker options as an additional argument to a link request, since at that point we know  the descriptor won't change anymore.
> 
> Another design decision is to only allow a single instance of a linker option of a certain type (and they are stored internally in a `Map<Class<?>, Option>` as well). This makes it easier to determine whether a combination of linker options is valid.
> 
> Other option kinds that could be added in the future are listed in the JBS issue, but not part of this patch.

This pull request has now been integrated.

Changeset: 60a47cb0
Author:    Jorn Vernee <jvernee at openjdk.org>
URL:       https://git.openjdk.org/panama-foreign/commit/60a47cb071f48a44e95c3b4a6defcf477738db0d
Stats:     354 lines in 28 files changed: 184 ins; 115 del; 55 mod

8292047: Consider ways to add linkage parameters to downcall handles

Reviewed-by: mcimadamore

-------------

PR: https://git.openjdk.org/panama-foreign/pull/734