[foreign-memaccess+abi] RFR: 8292034: Improve javadoc after memory segment/memory address unification [v2]

Jorn Vernee jvernee at openjdk.org
Fri Sep 23 15:34:39 UTC 2022


On Fri, 23 Sep 2022 15:25:45 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> I get your concern - however, by physical here we refer to the address that e.g. a C/C++ program would see. The fact that physical addresses are virtualized by the OS is a concern we gloss over here - honestly I don't think this is a big deal?
>
> I get what is meant by it, but I don't think "physical" is a great term wrt intuitive meaning. It would maybe be nice to define the term somewhere up front if we want to stick with "physical".

I think for regular Java developers, there is probably a much less clear distinction between heap/off-heap and "physical" memory in the first place.

i.e. if heap memory is the part of memory that is used to store Java objects, and off-heap is the part of memory that _isn't_ used to store Java objects, then I guess "physical memory" is just all of memory combined? Maybe just saying "memory" is enough? In the above, that could make:

    The {@linkplain #address() address} of a native segment (including mapped segments) denotes the starting address of the region of memory which backs the segment.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/730


More information about the panama-dev mailing list