[foreign-memaccess+abi] RFR: 8313238: Improve the performance of strlen for null-terminated strings

[ExE Boss]

On Thu, 3 Aug 2023 13:52:27 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to use native calls for determining the string length for C-type strings. 
> 
> Smaller segments (<1024 bytes) is using a trivial call whereas all other segments are using a normal call. We might consider always using regular calls if we think most segments are unbound anyhow.
> 
> The PR also contains a number of new tests, one of which requires a large heap size to run. It is likely that this latter test will not run in most test environments. In such cases, it is silently ignored.

src/java.base/share/classes/jdk/internal/foreign/StringSupport.java line 132:

> 130:             }
> 131:             return (int)len;
> 132:         } catch (Throwable e) {

This should rethrow `Error`s and `RuntimeException`s:
Suggestion:

        } catch (RuntimeException | Error e) {
            throw e;
        } catch (Throwable e) {

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/857#discussion_r1283510839