[foreign-memaccess+abi] RFR: Avoid using StandardCharset in Java code [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Aug 15 09:48:28 UTC 2023


On Tue, 15 Aug 2023 08:13:20 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> According to a comment in `java.nio.charset.StandardCharsets`, the use of this class should be avoided from elsewhere in the `jdk.base` module. This PR proposes removing all such direct use of said class in Java code (but not in JavaDocs).
>> 
>> 
>> public final class StandardCharsets {
>> 
>>     // To avoid accidental eager initialization of often unused Charsets
>>     // from happening while the VM is booting up, which may delay
>>     // initialization of VM components, we should generally avoid depending
>>     // on this class from elsewhere in java.base.
>
> Per Minborg has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove benchmark
>  - Use a faster if rake

Looks good

-------------

Marked as reviewed by mcimadamore (Committer).

PR Review: https://git.openjdk.org/panama-foreign/pull/864#pullrequestreview-1578263183


More information about the panama-dev mailing list