[foreign-memaccess+abi] RFR: Improve strlen performance [v3]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Aug 15 09:51:28 UTC 2023


On Mon, 14 Aug 2023 10:37:58 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR suggests removing the use of native calls for strlen and instead use Java implementations.
>> 
>> The PR also suggest performance improvements for quad word strlen.
>> 
>> Here are some benchmarks that compares the performance of the new proposed methods with the performance of the JDK 21 variants (called "legacy" methods):
>> 
>> <img width="2596" alt="image" src="https://github.com/openjdk/panama-foreign/assets/7457876/c785f341-c826-4e3e-bf56-8387b1e96010">
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Undo some unintended changes and clean up

test/jdk/java/foreign/TestStringEncoding.java line 195:

> 193:             return;
> 194:         }
> 195:         for (var charset:singleByteCharsets()) {

need spaces around `:`

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/862#discussion_r1294396275


More information about the panama-dev mailing list