[foreign-memaccess+abi] RFR: Improve strlen performance [v4]

[Maurizio Cimadamore]

On Tue, 15 Aug 2023 13:33:46 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> The proposed solution retains the same semantics as the old method where we would get an alignment error if presented with an unaligned MS (e.g. `alignedSegment.asSlice(1)`) but with improved performance (see the benchmarks at the top).
>
> Ok, I understand you might see improved numbers. What I'm saying is that in principle this trick should not be necessary: the loop is a counted loop, and we know we're incrementing by 8 on each iteration. So the alignment check should be hoist-able as once we check the base address there's nothing more to check.

So, I'd suggest to capture this in a small benchmark, and perhaps file a C2 compiler issue.

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/862#discussion_r1294622629