[foreign-memaccess+abi] RFR: 8314592: Add shortcut to SymbolLookup::find

Per Minborg pminborg at openjdk.org
Mon Aug 21 07:36:50 UTC 2023


On Fri, 18 Aug 2023 17:05:46 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This patch adds a default method in `SymbolLookup`, namely `SymbolLookup::get`. Its implementation is very simple: it calls `SymbolLookup::find` and then `Optional::get` on the result. This allows to simplify many clients that end up calling `Optional::get` or `Optional::orElseThrow` after a symbol lookup, but still retains the compositional advantage of the optional-returning lookup primitive.

I think the idea of having such a method is good (especially if the exception provides more information as to what went wrong) but I was also expecting a name indicating something would be thrown if the symbol was not found. The meaning of `get` is different in the JDK with `Map::get` returning `null` and `Optional::get` throwing for example.

-------------

PR Comment: https://git.openjdk.org/panama-foreign/pull/871#issuecomment-1685803616


More information about the panama-dev mailing list