[foreign-memaccess+abi] RFR: Clarify javadoc w.r.t. exceptions thrown by a memory access var handle (part two)
Radoslaw Smogura
duke at openjdk.org
Mon Aug 21 13:42:52 UTC 2023
On Mon, 21 Aug 2023 12:35:08 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This is a follow-up on https://git.openjdk.org/panama-foreign/pull/869 which fixes two issues:
> * the rectified javadoc still did not mention possibility of `WrongThreadException`
> * `MemoryLayout::sliceHandle` needs similar clarifications (albeit some exceptions can't occur there)
>
> To make the javadoc a bit more streamlined, I've collected all the checks in bullet lists.
src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 454:
> 452: * an {@link IllegalArgumentException} will be issued. Note that the alignment constraint of the root layout
> 453: * can be more strict (but not less) than the alignment constraint of the selected value layout.</li>
> 454: * <li>The offset of the access operation (computed as above) must fall fall inside the spatial bounds of the
Just saw it - double `fall fall`.
-------------
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/872#discussion_r1300128163
More information about the panama-dev
mailing list