[foreign-memaccess+abi] RFR: 8301261: Add linker option for specifying uncaught exception handler [v2]
David Holmes
dholmes at openjdk.org
Mon Feb 6 00:00:10 UTC 2023
On Fri, 3 Feb 2023 17:11:51 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> This patch adds the ability to specify an uncaught exception handler for an upcall stub, and changes the uncaught exception handling code to delegate to the thread's installed uncaught exception handler when no handler is specified as well, which will also allow setting a system-wide uncaught exception handler.
>>
>> For the tests: I've refactored TestUpcallException a bit. Previously the test code was found in a separate class (ThrowingUpcall). I've removed this class and moved the code into nested classes of TestUpcallException instead. Then I've added new test cases for testing the uncaught exception handler.
>>
>> I also noticed that we were setting the wrong system property to control binding recipe specialization in several tests (I thought I fixed this before, but it might have been undone by a merge...). I've fixed these to set the right property, and that also revealed a small bug in the interpreted version of the UnboxAddress binding, where we weren't properly reject heap segments. I've fixed that as well.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> review comments
FTR I think this is not a good idea with regards to using the Thread's UEH. That is only supposed to be called as a thread terminates due to the uncaught exception.
-------------
PR: https://git.openjdk.org/panama-foreign/pull/777
More information about the panama-dev
mailing list