[foreign-memaccess+abi] RFR: Deduplicate layouts and simplify value layout implementations [v3]
Per Minborg
pminborg at openjdk.org
Thu Feb 16 09:50:51 UTC 2023
On Thu, 16 Feb 2023 09:44:19 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes adding deduplication of the immutable value layout where one provides a value that is equal to the one already at hand. For example, `JAVA_INT.withBitAlignment(32)` will return the same object. There is no general caching mechanism that guarantees a layout will never repeat.
>>
>> Another part of this PR relates to simplifying value layouts so they only have a single constructor. This will reduce size slightly. Related to this is the replacement of certain magic numbers which are now represented by constants.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove dedup for names and clean up
The PR is more aimed at cases where there is something like this:
private static final MY_INT = JAVA_INT.withOrder(ByteOrder.LITTLE_ENDIAN);
private static final OTHER_INT = JAVA_INT.withBitAlignment(32);
I am happy to close this PR if the quorum is this would provide relatively little benefit compared to the added complexity.
-------------
PR: https://git.openjdk.org/panama-foreign/pull/795
More information about the panama-dev
mailing list