[foreign-memaccess+abi] RFR: 8295290: Add Windows ARM64 ABI support to the Foreign Function & Memory API [v3]

[Saint Wesonga]

On Tue, 10 Jan 2023 17:47:31 GMT, Saint Wesonga <duke at openjdk.org> wrote:

>> Saint Wesonga has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Remove redundant check
>>  - Delete VaList
>>  - Merge branch 'foreign-memaccess+abi' into WindowsAArch64ABI
>>  - Merge branch 'foreign-memaccess+abi' into WindowsAArch64ABI
>>  - Update Windows FFM implementation to match latest Preview API
>>  - Merge branch 'foreign-memaccess+abi' into WindowsAArch64ABI
>>  - Simplify newly added tests in TestVarArgs
>>  - Move storage decisions into StorageCalculator
>>  - Remove toSessionImpl method
>>  - Remove unnecessary null check
>>  - ... and 2 more: https://git.openjdk.org/panama-foreign/compare/5427e47b...ccae2d80
>
>> Few more comments inline.
>> 
>> FWIW, I think CallArranger can be cleaned up further, and I've been playing with a patch [1](https://github.com/openjdk/panama-foreign/compare/pull/754/head...JornVernee:panama-foreign:Refector_CallArranger). But I'll file a followup PR for that.
> 
> @JornVernee just to clarify, do you expect more refactoring of the CallArranger in this PR or will that be subsumed by your patch?

> @swesonga Hey, just a heads up. It is about that time again where we are looking to put together a PR for the JEP to go into mainline.
> 
> Since we do not support Windows/AArch64 (e.g. we can not test it), we can not be in charge of a PR that brings this port over to mainline. So, I think it's up to you or another maintainer of Windows/AArch64.
> 
> I suggest taking the following two commits:
> 
> 1. [d379ca1](https://github.com/openjdk/panama-foreign/commit/d379ca1ca32926591fbf8a4afdae1a4a52b3cb63)
> 2. [08225e4](https://github.com/openjdk/panama-foreign/commit/08225e4f5e00837e974098a933f27267f3c0dbc5)
> 
> And making a PR against openjdk/jdk out of those (since those three are all related to this port). I can approve it again there, since I've already reviewed the changes before.

@JornVernee I've opened https://github.com/openjdk/jdk/pull/12773

-------------

PR: https://git.openjdk.org/panama-foreign/pull/754