[vectorIntrinsics+fp16] RFR: 8290204: FP16 initial backend implementation [v4]

Bhavana Kilambi bkilambi at openjdk.org
Fri Jan 6 16:23:12 UTC 2023


On Wed, 21 Dec 2022 22:15:12 GMT, Smita Kamath <svkamath at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.cpp line 295:
>> 
>>> 293: // Return the vector operator for the specified scalar operation
>>> 294: // and vector length for half float
>>> 295: int VectorNode::opcode(int sopc) {
>> 
>> Hi, where is this function being referenced ? Should extra handling be added in this method - https://github.com/openjdk/panama-vector/blob/113ec5d22a8f1eff42e84e7c30472c78f89d7a36/src/hotspot/share/opto/vectorIntrinsics.cpp#L349 to generate a call to this function - VectorNode::opcode(int sopc) added in this PR ?
>
> Hi Bhavana, apologies for the delay in responding to your comment. The code to stitch everything together will be added later.

Hi Smitha, one more question - Since HalfFloat is not primitive datatype, the check to make sure the elem_type is primitive type might fail in LibraryCallKit::inline_vector_nary_operation(int n). Will you also be handling this?

-------------

PR: https://git.openjdk.org/panama-vector/pull/204


More information about the panama-dev mailing list