[vectorIntrinsics+fp16] RFR: 8290204: FP16 initial backend implementation [v6]

Smita Kamath svkamath at openjdk.org
Thu Jan 19 23:21:40 UTC 2023


On Mon, 16 Jan 2023 13:19:50 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> Smita Kamath has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Correction in HF2D node
>>  - typo in D2HF node
>>  - Updated cast instructs with new nodes
>
> src/hotspot/share/opto/classes.hpp line 412:
> 
>> 410: macro(DivVF)
>> 411: macro(DivVD)
>> 412: macro(DivVHF)
> 
> Hi, in a previous commit, the DIV operation wasn't added in the binary operations list for Halffloats here - https://github.com/openjdk/panama-vector/blob/9113b206b4a32ff65cb76c6003adb3b1b9738712/src/jdk.incubator.vector/share/classes/jdk/incubator/vector/HalffloatVector.java#L789
> Although this PR is specifically for backend impl but the backend ISA for "div" operation might not be generated due to this operation not being added to the list of binaryoperations for Halffloat. Is it possible to please add it in this PR?
> Thanks

Hi Bhavana, there will be a follow up PR that Swati will work on to add div to the list of binary ops for Halffloat.

-------------

PR: https://git.openjdk.org/panama-vector/pull/204


More information about the panama-dev mailing list