[foreign-memaccess+abi] RFR: 8287516: Implement fallback Linker [v6]

Jorn Vernee jvernee at openjdk.org
Fri Jan 20 15:48:08 UTC 2023


On Fri, 20 Jan 2023 15:03:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make struct layout check not based on field names
>
> src/java.base/share/classes/jdk/internal/foreign/abi/fallback/FFIType.java line 141:
> 
>> 139:                     }
>> 140:                 }
>> 141:                 expectedOffset += element.byteSize();
> 
> I think the offset should only be added for structs, not for unions

We can never encounter a union layout in this code. In libffi they are represented as a single element struct.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/770


More information about the panama-dev mailing list