[foreign-memaccess+abi] RFR: 8300785: Add way to select group element paths by index

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Jan 20 16:13:55 UTC 2023


On Fri, 20 Jan 2023 16:10:02 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> test/jdk/java/foreign/TestLayoutPaths.java line 113:
>> 
>>> 111:         g.byteOffset(groupElement(-1));
>>> 112:     }
>>> 113: 
>> 
>> Maybe you could add another test case that tests an index that is too large. e.g. `2` for a struct with 1 element.
>
> Good point - it was my intention but got distracted :-)

actually... there is such a test:


@Test(expectedExceptions = IllegalArgumentException.class)
    public void testTooBigGroupElementIndex() {
        GroupLayout g = MemoryLayout.structLayout(JAVA_INT);
        g.byteOffset(groupElement(1));
    }

-------------

PR: https://git.openjdk.org/panama-foreign/pull/773


More information about the panama-dev mailing list