[foreign-memaccess+abi] RFR: 8313265: Move the FFM API out of preview

[Jorn Vernee]

On Thu, 27 Jul 2023 17:46:55 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Move the FFM API out of preview, by removing preview feature annotations from the implementation, and adjusting the tests to no longer use `--enable-preview`

src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 69:

> 67:         // not used, but required for interim javac to not warn.
> 68:         VIRTUAL_THREADS,
> 69:         FOREIGN,

Note that I had to leave the enum constant here for now, since otherwise we encounter a warning when building interim javac.


* For target buildtools_interim_langtools_modules_java.compiler.interim__the.BUILD_java.compiler.interim_batch:
warning: unknown enum constant Feature.FOREIGN
error: warnings found and -Werror specified
1 error
1 warning

test/jdk/java/foreign/enablenativeaccess/TestEnableNativeAccessJarManifest.java line 34:

> 32:  *        panama_module/*
> 33:  *        org.openjdk.foreigntest.unnamed.PanamaMainUnnamedModule
> 34:  * @run testng/othervm TestEnableNativeAccessJarManifest

Note that `/othervm` is needed here, since removing `@enablePreview` makes the `jdk.module.path` system property `null` in the test without it.

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/853#discussion_r1276624437
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/853#discussion_r1276625900