[foreign-memaccess+abi] RFR: 8291639: Improve the ability to visualize a MemorySegment in human readable forms [v18]

[Jorn Vernee]

On Mon, 5 Jun 2023 13:25:55 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clean up code
>
> src/java.base/share/classes/java/lang/foreign/GroupLayout.java line 94:
> 
>> 92:      * a {@link MemorySegment} {@code ms} and produces a value for {@code c_a}.
>> 93:      * <p>
>> 94:      * Let {@code L} be a group layout with the elements {@code e_1, e_2, ..., e_M}, where {@code M >= N}.
> 
> WRT terminology: in other documentation 'elements' is used for sequence layouts, but 'member layouts' is used to GroupLayouts. So, I think the latter should be used here as well.

Along that same line of thought: maybe instead of `e_a`, `ml_a` could be used.

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/833#discussion_r1218087233