[foreign-memaccess+abi] RFR: 8310362: Improve composability of handle derived from layouts [v3]

Jorn Vernee jvernee at openjdk.org
Thu Jun 22 23:20:29 UTC 2023


On Thu, 22 Jun 2023 23:16:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more review comments
>
> src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 341:
> 
>> 339:      * @param offset the base offset
>> 340:      * @param index the index to be scaled by the byte size of this layout
>> 341:      * @throws IllegalArgumentException if {@code offset} is negative
> 
> also if `index` is negative?

Ah, right :)

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/840#discussion_r1239118183


More information about the panama-dev mailing list