[foreign-memaccess+abi] RFR: 8303666: Move address layout outside of ValueLayout namespace [v2]

[Jorn Vernee]

On Mon, 6 Mar 2023 16:24:22 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This patch moves ValueLayout.OfAddress into a toplevel class. This seems desirable since address layouts are very important in the FFM API, and also provides seadditional methods on top of `ValueLayout` to get/set a *target layout*.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add copyright header

Marked as reviewed by jvernee (Committer).

src/java.base/share/classes/java/lang/foreign/AddressLayout.java line 46:

> 44:  * layout is used to model the layout of the region of memory whose address is described by that address layout.
> 45:  * For instance, if an address layout has target layout {@link ValueLayout#JAVA_INT}, the region of memory pointed to by the address
> 46:  * described by the address layout is 4 bytes long. Specifying a target layout can be useful in the following situations:

Some redundant text here it seems
Suggestion:

 * For instance, if an address layout has target layout {@link ValueLayout#JAVA_INT}, the region of memory 
 * described by the address layout is 4 bytes long. Specifying a target layout can be useful in the following situations:

-------------

PR: https://git.openjdk.org/panama-foreign/pull/811