[foreign-memaccess+abi] RFR: 8303888: Add AddressLayout.withoutTargetLayout

Maurizio Cimadamore mcimadamore at openjdk.org
Thu Mar 9 11:35:46 UTC 2023


On Thu, 9 Mar 2023 11:32:23 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR proposes to add a `AddressLayout.withoutTargetLayout()` method for symmetry reasons. This allows  AddressLayout to be converted back to raw addresses.
>> 
>> Discussion point: Should this method require native access?
>
> src/java.base/share/classes/java/lang/foreign/AddressLayout.java line 115:
> 
>> 113:      * @see #targetLayout()
>> 114:      */
>> 115:     AddressLayout withoutTargetLayout();
> 
> The term "raw address" is not defined elsewhere. I'd suggest to leave the last sentence out, and maybe replace it with something similar to what you did for "withoutName" (e.g. useful to compare, yada yada).

And, no need to make this a restricted method, because this effectively turns a "more privileged" address layout into a "less privileged" one.

-------------

PR: https://git.openjdk.org/panama-foreign/pull/815


More information about the panama-dev mailing list