[foreign-memaccess+abi] RFR: 8305087: MemoryLayout API checks should be more eager [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Mar 29 11:35:36 UTC 2023
On Wed, 29 Mar 2023 07:32:39 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update src/java.base/share/classes/java/lang/foreign/GroupLayout.java
>>
>> Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>
>
> test/jdk/java/foreign/TestLayoutPaths.java line 219:
>
>> 217: ValueLayout.JAVA_CHAR.withBitAlignment(8).withName("1"),
>> 218: ValueLayout.JAVA_FLOAT.withBitAlignment(8).withName("2"),
>> 219: ValueLayout.JAVA_LONG.withBitAlignment(8).withName("3")
>
> Maybe there should be an alias for `withBitAlignment(8)`? E.g. `JAVA_LONG.withoutAlignment()`.
good suggestion - but I think outside the scope of this PR
-------------
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/824#discussion_r1151793371
More information about the panama-dev
mailing list