[foreign-memaccess+abi] RFR: 8291639: Improve the ability to visualize a MemorySegment in human readable forms [v2]

[Maurizio Cimadamore]

On Fri, 26 May 2023 13:06:57 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR proposes to add a "Record Mapper" that allows `MemorySegment` instances to be projected onto `Record` types given `GroupLayout` instances.
>> 
>> Here is a simple example of how to use the mapper:
>> 
>> 
>>     private static final GroupLayout POINT_LAYOUT = MemoryLayout.structLayout(
>>             JAVA_INT.withName("x"),
>>             JAVA_INT.withName("y"));
>> 
>>     MemorySegment segment =  MemorySegment.ofArray(new int[]{3, 4});
>> 
>>     Point point = POINT_LAYOUT.recordMapper(Point.class)
>>           .apply(segment); // Point[x=3, y=4]
>> 
>> 
>> I think the implementation can be improved later, for example by de-duplicating handling of arrays and maybe add recursive "un-pealing" of multidimensional arrays.
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
> 
>  - Merge master
>  - Fix typos
>  - Clean up toString methods
>  - Add support for MemoryAddress arrays and improve docs
>  - Improve javadoc
>  - Change to IAE if mapper fails
>  - Remove caching
>  - Add tests for initial issue examples
>  - Clean up and optimize
>  - Add support for multidimensional records
>  - ... and 19 more: https://git.openjdk.org/panama-foreign/compare/bee4503b...1d7db589

src/java.base/share/classes/jdk/internal/foreign/LayoutRecordMapper.java line 220:

> 218:                                             // (MemorySegment)
> 219:                                             mh = MethodHandles.insertArguments(mh, 1, leafArrayMapper);
> 220:                                             yield castReturnType(mh, cl.component().getType());

I'm not sure about this and other casts in this branch of the code. isn't the method handle here returning some T[] ? If so, how can we cast it to the component type of cl? (btw, we already have `cl.componentType` stored in a variable, I think).

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/833#discussion_r1206914585