[foreign-memaccess+abi] RFR: 8291639: Improve the ability to visualize a MemorySegment in human readable forms [v6]

Glavo duke at openjdk.org
Mon May 29 10:26:20 UTC 2023


On Mon, 29 May 2023 07:59:40 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> This PR proposes to add a "Record Mapper" that allows `MemorySegment` instances to be projected onto `Record` types given `GroupLayout` instances.
>> 
>> Here is a simple example of how to use the mapper:
>> 
>> 
>>     private static final GroupLayout POINT_LAYOUT = MemoryLayout.structLayout(
>>             JAVA_INT.withName("x"),
>>             JAVA_INT.withName("y"));
>> 
>>     MemorySegment segment =  MemorySegment.ofArray(new int[]{3, 4});
>> 
>>     Point point = POINT_LAYOUT.recordMapper(Point.class)
>>           .apply(segment); // Point[x=3, y=4]
>> 
>> 
>> I think the implementation can be improved later, for example by de-duplicating handling of arrays and maybe add recursive "un-pealing" of multidimensional arrays.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add JLS reference

src/java.base/share/classes/jdk/internal/foreign/LayoutRecordMapper.java line 53:

> 51: import java.util.function.Function;
> 52: import java.util.stream.Collectors;
> 53: import java.util.stream.IntStream;

redundant import

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/833#discussion_r1209170318


More information about the panama-dev mailing list