[foreign-memaccess+abi] RFR: Beef up javadoc for base offset in var handles derived from layouts [v2]
Jorn Vernee
jvernee at openjdk.org
Wed Oct 4 19:18:40 UTC 2023
On Wed, 4 Oct 2023 18:00:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> This PR adds more javadoc to explain how base offsets in var handles obtained from layouts can be used.
>>
>> First, a number of examples in the main `MemoryLayout` javadoc is rectified, as such examples did not use the additional base offset parameter (and were hence incorrect).
>>
>> Second, the var handles part in the `MemorySegment` section on "accessing memory segment" has been rewritten to avoid duplication with the concepts exposed in `MemoryLayout`. Now we show how `MemorySegment::get` and `MemorySegment::getAtIndex` can be obtained using basic var handles and combinators. We mention that more complex var handles can be obtained using layout paths, but we now just reference the layout path section.
>>
>> Last, I've added a new section on the `MemoryLayout` javadoc, with an example on how to deal with variable-length structs. This example showcases how var handles can be used in intricate situations, and combined with the new `scaleOffset` method.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
Marked as reviewed by jvernee (Committer).
-------------
PR Review: https://git.openjdk.org/panama-foreign/pull/901#pullrequestreview-1658321725
More information about the panama-dev
mailing list