[foreign-memaccess+abi] RFR: Fix sonar issues and thread safety bug

[Maurizio Cimadamore]

On Tue, 10 Oct 2023 09:27:43 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes some fix of Sonar warnings and a thread safety issue.

src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/windows/WindowsAArch64Linker.java line 52:

> 50: 
> 51:     public static WindowsAArch64Linker getInstance() {
> 52:         class Holder {

I suppose that is the multi-threaded fix?

src/java.base/share/classes/jdk/internal/foreign/abi/fallback/FFIType.java line 62:

> 60: final class FFIType {
> 61: 
> 62:     private FFIType() {}

I'd leave this out

-------------

PR Review Comment: https://git.openjdk.org/panama-foreign/pull/906#discussion_r1352089260
PR Review Comment: https://git.openjdk.org/panama-foreign/pull/906#discussion_r1352088235